Add NLS test scenario #6120
Merged
Add NLS test scenario #6120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- tests/Microsoft.DotNet.Docker.Tests/Microsoft.DotNet.Docker.Tests.csproj: Language not supported
- tests/Microsoft.DotNet.Docker.Tests/TestAppArtifacts/NLSTest.Dockerfile: Language not supported
- tests/Microsoft.DotNet.Docker.Tests/AspnetImageTests.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
tests/Microsoft.DotNet.Docker.Tests/TestScenarios/NLSScenario.cs:54
- Incorrect array initializer syntax. Use curly braces '{}' instead of square brackets '[]'.
string[] buildArgs = [
tests/Microsoft.DotNet.Docker.Tests/RuntimeImageTests.cs:52
- Ensure that the new
VerifyNLSScenariomethod is covered by tests.
public async Task VerifyNLSScenario(ProductImageData imageData) =>
mthalman
reviewed
Jan 6, 2025
tests/Microsoft.DotNet.Docker.Tests/TestAppArtifacts/NLSTest.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.DotNet.Docker.Tests/TestScenarios/NLSScenario.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.DotNet.Docker.Tests/TestScenarios/NLSScenario.cs
Outdated
Show resolved
Hide resolved
mthalman
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NLS is Windows-only, so I defined a completely separate scenario for it that runs only on Windows.
The test uses the recommended method for determining whether or not we're using ICU, and then validates some of the differences between NLS and ICU behavior based on what it finds.
For now, we will expect that NLS is used on all Nano Server images, and ICU is used on all Windows Server Core images. ICU has been the default on Server Core since .NET 7 and Server Core LTSC 2019. See https://learn.microsoft.com/en-us/dotnet/core/compatibility/globalization/7.0/icu-globalization-api for more context there.